AP-613 convert oclc number to int if it's a float in the spreadsheet#7
Open
davezuckerman wants to merge 1 commit intomainfrom
Open
AP-613 convert oclc number to int if it's a float in the spreadsheet#7davezuckerman wants to merge 1 commit intomainfrom
davezuckerman wants to merge 1 commit intomainfrom
Conversation
converting oclc numbers to floats in spec removed spaces at end of line for rubocop bumped nokogiri to 1.19 and ruby to 3.3 forgot to update the build and gem push files with the updated ruby version updated rubocop target to ruby 3.3 bumped rubocop version
awilfox
reviewed
Mar 13, 2026
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looking good. One minor typo, and a question on Rubocop version pinning, then r+.
| return to_enum(:each_oclc_number) unless block_given? | ||
|
|
||
| ss.each_value(oclc_col_index, include_header: false) do |v| | ||
| # convert to integer if oclc number is a float in the spreadsheet" |
Member
There was a problem hiding this comment.
Suggested change
| # convert to integer if oclc number is a float in the spreadsheet" | |
| # convert to integer if oclc number is a float in the spreadsheet |
| spec.add_development_dependency 'rake', '~> 13.0' | ||
| spec.add_development_dependency 'rspec', '~> 3.10' | ||
| spec.add_development_dependency 'rubocop', '= 1.39' | ||
| spec.add_development_dependency 'rubocop', '~> 1.75' |
Member
There was a problem hiding this comment.
Do we want to ~> 1.75? This will automatically pull in newer versions (and potentially change reports/passes) whenever dependencies are updated. We did ~> 1.84.0 in UCBEARS and ~> 1.77.0 in Framework; should this be ~> 1.75.0 instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped ruby version to 3.3
Bumped rubocop to 1.75
Bumped nokogiri to 1.19.1
Converts oclc number to an integer if it's a float in the spreadsheet